Improved Items Mover ( multi items )

[kamilqq]

Hello, now ive just had a need to make better item mover, so i'd like to share with community

I did not made optional backpack where pots firstly are because usually people want to sort items after magic shop. So thats why it sorting from first backpack( usually main ).

Also you don't have to loop this function:
reason of looping such function is that when you move item, the next indexes are lowered by 1 and for loop just goes ahead.
There is no such problem cause this is recursive function so if it will move item its looping itself.

I hope You enjoy

 toSort = {
    {id = Item.GetID('mana potion'), bp = 'brocade backpack'},
    {id = Item.GetID('health potion'), bp = 'demon backpack'}
    }
function moveItems(table)
    local fromBP = Container.GetFirst()
    for spot, item in fromBP:iItems() do
        for _, data in pairs(table) do
            if item.id == data.id then
                local toBP = Container.New(data.bp)
                fromBP:MoveItemToContainer(spot, toBP:Index(), 0)
                     wait(Self.Ping() + 100, Self.Ping() + 300)
                return moveItems(table)
            end
        end
    end
end
Module.New('ImprovedItemMover', function(this)
    moveItems(toSort)
    this:Stop()
    end) 

[Mvm1]

Awesome man! Thanks for sharing it.

Works 100%

[kamilqq]

Awesome man! Thanks for sharing it.

Works 100%

Thanks

[maroxy]

lua code:

return moveItems(table)

Why?

[kamilqq]

lua code:

return moveItems(table)

Why?

Read my post once more, it's recursive function. Read about that. I said about index changing in function.
If bot took one item, the rest items are index - 1, so it missing some items. Now when i did recursive function, ill give u definition:
You move one item > rest item indexes are -1 so next item is ignored, when i did recursive function the function is executed once more from 0. So its looping from 0 ( after one item moved ) until no item is moved.

[maroxy]

Read my post once more, it's recursive function. Read about that. I said about index changing in function.
If bot took one item, the rest items are index - 1, so it missing some items. Now when i did recursive function, ill give u definition:
You move one item > rest item indexes are -1 so next item is ignored, when i did recursive function the function is executed once more from 0. So its looping from 0 ( after one item moved ) until no item is moved.

That makes sense.

Anyways if you are thinking of that use just a "break", cause you are executing function over function and maybe it can cause a memory leak. (Not sure about this )

[kamilqq]

That makes sense.

Anyways if you are thinking of that use just a "break", cause you are executing function over function and maybe it can cause a memory leak. (Not sure about this )

Read about functions. ( im not aggressive saying that )
Explain :
1. return statement is breaking loop. Here it breaks the function and executes once more itself(if moved any item).
2. it only return new loop ( self ) if found and moved item. So if it will not find any item then it wont loop itself.
Also the module there is just useless ( better to just execute function at label or something like that ), i used here Module to show how it works.

[maroxy]

Read about functions. ( im not aggressive saying that )
Explain :
1. return statement is breaking loop. Here it breaks the function and executes once more itself(if moved any item).
2. it only return new loop ( self ) if found and moved item. So if it will not find any item then it wont loop itself.
Also the module there is just useless ( better to just execute function at label or something like that ), i used here Module to show how it works.

You are right!

Keep the good work.

[Jontor]

You might want to add a delay to the code

[kamilqq]

You might want to add a delay to the code

Also the module there is just useless ( better to just execute function at label or something like that ), i used here Module to show how it works.

Read it.